Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kiota abstr to >=1.3.0 due to multipart support #817

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Bump kiota abstr to >=1.3.0 due to multipart support #817

merged 1 commit into from
Jul 17, 2024

Conversation

Acurisu
Copy link
Contributor

@Acurisu Acurisu commented Jul 17, 2024

Due to the reliance on the multipart support added in v1.3.0 of https://github.com/microsoft/kiota-abstractions-python, as seen in

msgraph-sdk-python/msgraph/generated/base_graph_service_client.py

Line 12 in 2ef486c

from kiota_serialization_multipart.multipart_serialization_writer_factory import MultipartSerializationWriterFactory
, I would advocate for bumping the minimum version specified inside pyproject to reflect said dependency. Otherwise, upgrading the pip module will not bump kiota abstractions.

@Acurisu Acurisu requested a review from a team as a code owner July 17, 2024 06:43
baywet
baywet approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this .
Would you mind doing the same on the beta repository please?

@baywet baywet merged commit d6c9f86 into microsoftgraph:main Jul 17, 2024
7 checks passed
@Acurisu Acurisu mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Acurisu @baywet