Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose type information #872

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Expose type information #872

merged 6 commits into from
Aug 29, 2024

Conversation

shemogumbe
Copy link
Collaborator

Closes #655

Before
When importing classes from this project, an error is shown:

auth_update.py:5: error: Skipping analyzing "msgraph": module is installed, but missing library stubs or py.typed marker [import-untyped]

After:
With This PR, there are no reported errors on type checking and typechecking allows shows no issues

Success: no issues found in 1 source file

@shemogumbe shemogumbe requested a review from a team as a code owner August 26, 2024 13:19
@shemogumbe shemogumbe merged commit 4e01516 into main Aug 29, 2024
7 checks passed
@shemogumbe shemogumbe deleted the shem/expose_type_information branch August 29, 2024 08:17
@nitneuqr
Copy link

nitneuqr commented Nov 4, 2024

Hey! Just to let you know, mypy compatibility now makes the mypy commands outrageously slow (around 15 minutes for some type checkings in my code). It's probably due to the library's very big size.

I appreciate the feature, but I guess there are no ways to ignore this? Or probably do something around creating our own library using kiota to have a smaller Python library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msgraph package compatibility with mypy
3 participants