Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release please configs #886

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

shemogumbe
Copy link
Collaborator

No description provided.

@shemogumbe shemogumbe requested a review from a team as a code owner September 5, 2024 09:44
release-please-config.json Outdated Show resolved Hide resolved
@shemogumbe shemogumbe requested a review from baywet September 5, 2024 11:25
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@shemogumbe shemogumbe merged commit c172013 into main Sep 5, 2024
7 checks passed
@shemogumbe shemogumbe deleted the shem/fix_release_please_configs branch September 5, 2024 12:52
@baywet
Copy link
Member

baywet commented Sep 5, 2024

I didn't see it originally but it seems the space between the closing parenthesis and the colon makes the commit "invalid" from a conventional commit/release please perspective, not triggering the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants