Store reference inside Lazy when Lazy is marked (CDI integration) #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fh-ms
requested changes
Jul 11, 2022
| @@ -155,6 +155,10 @@ void initializePump() | |||
|
|
|||
| public void storeChanged(final Object dirtyInstance, final boolean clearLazy) | |||
| { | |||
| if (dirtyInstance instanceof Lazy) { | |||
| // When a Lazy is marked, the developer probably wants to store the referenced instance in the Lazy. | |||
| this.manager.store(((Lazy<?>) dirtyInstance).get()); | |||
There was a problem hiding this comment.
Lazy#get always loads the reference. I would recommend to use Lazy#peek
Object lazyRef = ((Lazy<?>)dirtyInstance).peek();
if(lazyRef != null)
{
this.manager.store(lazyRef);
}
fh-ms
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Lazyreference is marked by developer, the instance inside theLazyis also stored as that is probably the intention (and makes working and clearing with Lazy references easier).