fix 'cannot take exclusive lock for project' error #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const items: T[] = []; | ||
| let index = this.head; | ||
| for (let i = 0; i < this.size; i++) { | ||
| items.push(this.buffer[index]!); |
There was a problem hiding this comment.
Suggested change
| items.push(this.buffer[index]!); | |
| items.push(this.buffer[ (index+this.head) % this.size]!); |
There was a problem hiding this comment.
this might help in getting logs in order.
There was a problem hiding this comment.
I wanted it in order of creation. Wouldn't above suggestion return it in order the buffer is laid out in memory?
jayantbh
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI had an issue where it would throw error
cannot take exclusive lock for project "dora-metrics": process with PID 113930 is still running. This was caused by another instance of docker-watch running or not exiting properly. So the solution was to parse the log and look for this error. Then from that extract thePIDof the process and run the kill command. Now when we run the kill command we toggle the retry useState flag so that the useEffect starts again thereby starting docker-watch again.Now the other problem was that the error was getting caught due to process.on('close'.......) which in turn resulted in the execution of the handleExit() function. To avoid this, a circular buffer was created to store the last 10 logs, and when the 'close' event is triggered we search for the specific error and if found, we simply resolve the promise.