Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API for fetching deployments with related incidents #36

Merged
merged 9 commits into from
Apr 10, 2024
Merged

API for fetching deployments with related incidents #36

merged 9 commits into from
Apr 10, 2024

Conversation

samad-yar-khan
Copy link
Contributor

Proposed Changes

  • Add util for uuid strings
  • Add test factory for Incidents
  • Add repo method for team incidents and refactored incidents repo
  • Add method to map deployment with incidents get_deployment_incidents_map + added tests for the same
  • Add method to fetch all team deployments in interval
  • Add API for fetching deployment with related incidents

amoghjalan
amoghjalan approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@amoghjalan amoghjalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samad-yar-khan samad-yar-khan merged commit baeca4e into main Apr 10, 2024
1 check passed
@amoghjalan amoghjalan deleted the GROW-1216 branch May 3, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoghjalan amoghjalan amoghjalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samad-yar-khan @amoghjalan