Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mtd bookmark pushback to take minimum value #490

Merged
merged 2 commits into from
Jul 23, 2024
Merged

fix mtd bookmark pushback to take minimum value #490

merged 2 commits into from
Jul 23, 2024

Conversation

samad-yar-khan
Copy link
Contributor

@samad-yar-khan samad-yar-khan commented Jul 23, 2024 •
edited
Loading

Linked Issue(s)

Acceptance Criteria fulfillment

  • Fixes the bookmark logic

Proposed changes (including videos or screenshots)

  • The merge_to_deploy logic depends on the workflow as well as the PRs. For each workflow we calculate the MTD for previously merged PRs for null MTD values.
  • Incase the PRs are merge later we push the MTD bookmark so that mtd values are fixed on the next sync. This would require us to take the min of the existing bookmark and the pr merge times.
  • The current change enforces the above logic. The previous logic would not change the bookmark regardless of the PRs merge times.

Further comments

@samad-yar-khan samad-yar-khan merged commit 9339afc into main Jul 23, 2024
3 checks passed
@samad-yar-khan samad-yar-khan deleted the fix-mtd-broker branch July 23, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantbh jayantbh jayantbh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samad-yar-khan @jayantbh