Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings getters and setters to allow optional setter_id #77

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Update settings getters and setters to allow optional setter_id #77

merged 1 commit into from
Apr 13, 2024

Conversation

samad-yar-khan
Copy link
Contributor

@samad-yar-khan samad-yar-khan commented Apr 13, 2024 •
edited
Loading

Proposed Changes

  • Make setter_id optional in settings API
  • Remove user settings APIs

amoghjalan
amoghjalan approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@amoghjalan amoghjalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ensure that setter is nullable in db schema as well

@samad-yar-khan samad-yar-khan merged commit e1f5430 into main Apr 13, 2024
1 check passed
@samad-yar-khan samad-yar-khan deleted the GROW-1306 branch April 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoghjalan amoghjalan amoghjalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samad-yar-khan @amoghjalan