-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added handling for abbreviations #47
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b123fbc
added handling for abbreviations
15d54ad
reversed formatting
7098dd3
added test cases for abbreviations
7696a27
improved handling for abbreviations and degree symbols
25649f6
added installation for regex module
877df42
reversed change
e84e442
went back to re module
8a60543
old regex string, which was commented out, removed
66ffce0
updated regex string
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hættirðu við að styðja hástafi líka? Það er reyndar alveg spurning hvort leyfa eigi blandaða há- og lágstafi, eða hvort þarna ættu einfaldlega að vera tvær segðir, önnur fyrir hástafi eingöngu og hin fyrir lágstafi eingöngu. - Svo er spurning hvort við ættum að harðkóða undantekningu fyrir skammstöfunina "þ.á m." sem hefur mikla sérstöðu ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nei ég setti inn re.IGNORECASE í línu 3180 til þess að geta haft þessa segð styttri. Með því að leyfa blöndu grípum við skammstöfun í byrjun setningar, og svo er ágætt að geta gripið skrýtna hástöfun þó að hún sé málfræðilega röng.