Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization #49

Merged
merged 8 commits into from
Aug 23, 2024
Merged

Modernization #49

merged 8 commits into from
Aug 23, 2024

Conversation

sveinbjornt
Copy link
Member

@sveinbjornt sveinbjornt commented Aug 22, 2024

  • Version bumped to 3.4.5
  • Minimum Python version >=3.9
  • Python 3.13 compatibility by migrating from importlib's deprecated open_text method (TBD!)
  • Modern typing syntax for dict, list, etc.
  • Formatting and cleanup

@sveinbjornt sveinbjornt marked this pull request as draft August 22, 2024 19:50
@sveinbjornt sveinbjornt changed the title Bumped version to 3.4.5, bumped min Python version to 3.9, fmt, clean… Modernization Aug 22, 2024
Copy link
Member

@vthorsteinsson vthorsteinsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is the intent - in this PR, before merging - to move away from open_text() to avoid the deprecation warning?

@sveinbjornt
Copy link
Member Author

Looks good to me. Is the intent - in this PR, before merging - to move away from open_text() to avoid the deprecation warning?

Yes.

@sveinbjornt sveinbjornt marked this pull request as ready for review August 23, 2024 15:51
@sveinbjornt sveinbjornt merged commit 340ecb7 into master Aug 23, 2024
14 checks passed
@sveinbjornt sveinbjornt deleted the modernize branch August 23, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants