-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update toast component ♻️ #929
base: main
Are you sure you want to change the base?
Conversation
@Jesus-Rojas is attempting to deploy a commit to the midudev pro Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
✅ ¡Los conflictos han sido resuletos! Un colaborador revisará pronto la Pull Request. |
@midudev merge this !! |
Descripción
Existe demasiado condicional en la funcion toast, la mayoria de casos valida si existe o no cierto
toastOption
. Tambien he visto demasiadosstrings mágicos
.Cambios propuestos
Comprobación de cambios
Impacto potencial
En cuanto a
UX
no afecta, en cuanto a mantenibilidad si es necesario el cambio.