Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add baseDir to context #19

Merged
merged 3 commits into from
Sep 29, 2018
Merged

refactor: add baseDir to context #19

merged 3 commits into from
Sep 29, 2018

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Sep 27, 2018

1、将 baseDir,appDir 注入到上下文中,方便获取
2、增加 mm.cluster 对 midway 框架的识别

@codecov-io
Copy link

codecov-io commented Sep 27, 2018

Codecov Report

Merging #19 into master will increase coverage by 2.77%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   75.29%   78.07%   +2.77%     
==========================================
  Files          71       71              
  Lines        2097     2194      +97     
  Branches      314      338      +24     
==========================================
+ Hits         1579     1713     +134     
+ Misses        398      364      -34     
+ Partials      120      117       -3
Impacted Files Coverage Δ
packages/midway-core/src/loader.ts 79.34% <100%> (+2.68%) ⬆️
packages/midway-web/src/decorators/application.ts 100% <100%> (ø) ⬆️
packages/midway-mock/src/index.ts 63.15% <20%> (-15.42%) ⬇️
packages/context/src/annotation/objectDef.ts 84.37% <0%> (-12.06%) ⬇️
packages/context/src/base/FunctionDefinition.ts 47.72% <0%> (-0.66%) ⬇️
packages/context/src/base/ObjectDefinition.ts 100% <0%> (ø) ⬆️
packages/context/src/base/ObjectCreator.ts 49.23% <0%> (+3.07%) ⬆️
packages/context/src/factory/common/Autowire.ts 56.25% <0%> (+4.16%) ⬆️
packages/context/src/factory/container.ts 90.9% <0%> (+8.61%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01795eb...152d235. Read the comment docs.

@czy88840616 czy88840616 merged commit b29f516 into master Sep 29, 2018
@czy88840616 czy88840616 deleted the clean_code branch September 29, 2018 05:24
czy88840616 pushed a commit that referenced this pull request Sep 29, 2018
Merge pull request #19 from midwayjs/clean_code

refactor: add baseDir to context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants