Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RRSIG algorithm mnemonics #1456

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Allow RRSIG algorithm mnemonics #1456

merged 2 commits into from
Apr 28, 2023

Conversation

miekg
Copy link
Owner

@miekg miekg commented Apr 27, 2023

Java outputs these and the RFC says we should parse them, so parse
them. We'll never output them though. Throwback to the "be lenient to
what you accept, but strict with what you output". Anyhow the diff is
tiny and it helps interop.

Fixes: #1447

Signed-off-by: Miek Gieben miek@miek.nl

@miekg miekg requested a review from tmthrgd as a code owner April 27, 2023 17:57
Java outputs these *and* the RFC says we should parse them, so parse
them. We'll never output them though. Throwback to the "be lenient to
what you accept, but strict with what you output". Anyhow the diff is
tiny and it helps interop.

Fixes: #1447

Signed-off-by: Miek Gieben <miek@miek.nl>
parse_test.go Outdated Show resolved Hide resolved
Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg
Copy link
Owner Author

miekg commented Apr 28, 2023 via email

@miekg miekg merged commit d4a9e37 into master Apr 28, 2023
@miekg miekg deleted the rrsig-sig-men branch April 28, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RRSIG parsing does not accept algorithm code in mnemonic form
1 participant