Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper section names when producing dig-like output for UPDATEs #1479

Merged
merged 1 commit into from Sep 12, 2023
Merged

Use proper section names when producing dig-like output for UPDATEs #1479

merged 1 commit into from Sep 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 12, 2023

When Opcode == OpcodeUpdate, String() should use section names as described in RFC 2136 Section 2:

Query -> Zone
Answer -> Prerequisite
Authority -> Update

@ghost ghost requested review from miekg and tmthrgd as code owners September 12, 2023 00:35
@tmthrgd
Copy link
Collaborator

tmthrgd commented Sep 12, 2023

That's annoying, but I suppose if this is the correct output we should do it.

@miekg miekg merged commit a36acb4 into miekg:master Sep 12, 2023
4 checks passed
mloiseleur added a commit to mloiseleur/external-dns that referenced this pull request Dec 2, 2023
alitari pushed a commit to alitari/external-dns that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants