Keyframe jump feature behaves strangely when turning off showkeyframes

[andoruB]

Describe the bug
Keyframe jump feature behaves strangely when turning off showkeyframes. When disabling show keyframes option, I'm no longer able to seek properly to next keyframe

To Reproduce
Steps to reproduce the behavior:

1. Open video file
2. Use the seek keyframe button - works as expected
3. Disable showkeyframes option if it was already enabled
4. Use seek keyframe button - jumps randomly to an earlier part of the video instead of jumping to the next keyframe, or doesn't do anything at all
5. Try out using the keyboard shortcuts instead - works as expected
6. Enable showkeyframes option again - works as expected with seek keyframe button

Expected behavior
To be able to disable showkeyframes option and to still be able to use the seek keyframes buttons

Desktop (please complete the following information):

• OS: Manjaro 21.2.2 Qonos - Cinnamon flavour + LosslessCut 3.42.0 Appimage

[mifi]

Actually the show keyframes button is not only for showing keyframes, but it's for enabling extraction of keyframes. What's the reason you need to hide keyframes but still want to "use" them?

[andoruB]

Ah, sorry, I was not aware it was supposed to be like this, thought it was a bug. I don't necessarily need it to work like this, just disabled show keyframes, as the videos that I usually cut are quite long, so that feature is useless to me. But will keep the feature on in this case.

[mifi]

Ok, I see. I'll close this then. Can revisit this if more people are confused by it

[cyzs233]

@mifi
currently, the Keyframe jump do have a bug, it jumps wildly if you click too fast. (introduced in recent update)
demo below, focus on the timestamps: :

[mifi]

@cyzs233 thanks for your report. Could this be happening because you don't have any keyframes loaded between 01:03 and 00:46? After #563 (comment) it will buffer old keyframes. So if there are no keyframes between, then it will jump to the previous keyframe which could be at 00:46

[cyzs233]

@cyzs233 thanks for your report. Could this be happening because you don't have any keyframes loaded between 01:03 and 00:46?

Seems to be 👍.
I noticed it was commented on Jan 16, so is this issue supposed to be fixed or will be in next update?

The buffer seems pretty small right now, only -20 seconds loaded, 1-2 minutes would be good enough for a rough search.

[mifi]

yes the buffer of 1000 last keyframes is already out. problem is that loading a long window of many minutes will take a long time

[cyzs233]

Fine, my laptop sure isn't very competitive, will be more patient next time. Although a faster loading speed is away appreciated

…

On Fri, 18 Feb 2022 at 22:17, Mikael Finstad ***@***.***> wrote: yes the buffer of 1000 last keyframes is already out. problem is that loading a long window of many minutes will take a long time — Reply to this email directly, view it on GitHub <#1018 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGFZ3M4ILZYXMQS2BCLBB3DU3ZIIRANCNFSM5NY3CMIQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>