Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req: audio waveform with zoom and thumbnails #6

Closed
FredThompsonII opened this issue Nov 6, 2016 · 14 comments
Closed

req: audio waveform with zoom and thumbnails #6

FredThompsonII opened this issue Nov 6, 2016 · 14 comments

Comments

@FredThompsonII
Copy link

Any plan to add audio waveform and a scrollbar with zoom in/out for time scale and thumbnails?
I ask because I'm currently using another app to cut long streaming files into pieces. Finding gaps between content is easier with a waveform (I look for empty regions) and thumbnails which can show standard intro/outro sections.

@mifi
Copy link
Owner

mifi commented Nov 6, 2016

It should be possible but I can imagine that it would require preprocessing in order to create thumbnails/waveform, and this will probably take some time, defeating the purpose of this being a very fast app.

@TechManiacHD
Copy link

Would be nice to have but not that essential INHO. Program is currently blazing fast so adding this future might hurt it.

@opusforlife2
Copy link

https://trac.ffmpeg.org/wiki/Waveform

@mifi Have you looked at this filter? It's a part of ffmpeg.

@mifi
Copy link
Owner

mifi commented Feb 26, 2020

mifi added a commit that referenced this issue Feb 27, 2020
also try to improve zooming
@mifi
Copy link
Owner

mifi commented Feb 27, 2020

Waveform and thumbnails is now implemented

@mifi mifi closed this as completed Feb 27, 2020
mifi added a commit that referenced this issue Feb 27, 2020
@WiliTest
Copy link

I wish I could use it to quickly trim audio, but the waveform is too small/basic. Would it be possible to add a real waveform, just for audio files (it's needed to find the right spot on long audio files)?

@opusforlife2
Copy link

I agree. With audio files, the entire space kept for video is wasted real estate. The audio waveform could be much bigger and easier to see.

Also, the waveform only shows up for part of the file. If you jump to another frame, the audio waveform gets extended further, but the beginning portion gets cut off. Is it a limitation that the entire waveform cannot be shown at once? One would think since it's a static property of a file, it could be loaded fully just once and that's it.

@mifi
Copy link
Owner

mifi commented Mar 28, 2020

It's a technical limitation because rendering the waveform takes a long time. So it will only render 30 seconds at a time. I'm not sure what is the best way to render a zoomed out waveform overview for the whole clip. See #260

@opusforlife2
Copy link

I'm not sure I get this. Rendering 30 seconds at a time shouldn't prevent you from still displaying the already rendered waveform. It's fine if a 2 minute song renders in 4 sections. Or is the problem something else?

@mifi
Copy link
Owner

mifi commented Mar 28, 2020

Yes, we could keep the already rendered waveform. I can make that change.

@opusforlife2
Copy link

With audio files, the entire space kept for video is wasted real estate. The audio waveform could be much bigger and easier to see.

And what is your opinion on this?

@mifi
Copy link
Owner

mifi commented Mar 28, 2020

And what is your opinion on this?

You mean you want it to be taller or expandable? That shouldn't be too hard

@opusforlife2
Copy link

Taller, definitely, like 6-7 times the current height. Something like the size Audacity shows, so that it is easy to comprehend and use.

Expandable is up to you.

@mifi
Copy link
Owner

mifi commented Jan 24, 2021

Closing in favor of #260

@mifi mifi closed this as completed Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants