Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require cabal-version 1.8 #2

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

felixonmars
Copy link
Contributor

Hopefully this suppresses the following warning:

Warning: readable.cabal:31:27: version operators used. To use version
operators the package needs to specify at least 'cabal-version: >= 1.8'.

Hopefully this suppresses the following warning:
```
Warning: readable.cabal:31:27: version operators used. To use version
operators the package needs to specify at least 'cabal-version: >= 1.8'.
```
@teto
Copy link

teto commented Jan 24, 2022

I see this message too. I approve of the change. I hope we can get ghc 9.2 support too (ready to help).

@mightybyte
Copy link
Owner

The last change to the cabal file was three years ago, so it doesn't seem like there's anything here that would have caused that warning. Why is narrowing the cabal version the fix to this?

Side note...totally open to PRs supporting more recent GHCs.

@teto
Copy link

teto commented Jan 24, 2022

it's a cabal change most likely. 1.8 should be fine (e.g it's pretty old) considering https://cabal.readthedocs.io/en/3.6/file-format-changelog.html#spec-history

@teto teto mentioned this pull request Jan 24, 2022
7 tasks
@teto
Copy link

teto commented Jul 29, 2022

any chance we an merge this ?

@mightybyte mightybyte merged commit a825b32 into mightybyte:master Nov 1, 2022
@felixonmars felixonmars deleted the patch-1 branch November 2, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants