Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rule @typescript-eslint/prefer-ts-expect-error #285

Merged
merged 1 commit into from
May 16, 2020
Merged

feat: rule @typescript-eslint/prefer-ts-expect-error #285

merged 1 commit into from
May 16, 2020

Conversation

mightyiam
Copy link
Owner

@mightyiam mightyiam requested review from LinusU and toddbluhm April 23, 2020 09:47
@mightyiam mightyiam force-pushed the prefer-ts-expect-error branch from a00594c to 3db785a Compare April 23, 2020 09:49
LinusU
LinusU approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make us require TypeScript 3.9 or newer, should probably document that somewhere ☺️

Actually, we should probably have a peer-dependency on typescript >= 3.9? 🤔

toddbluhm
toddbluhm approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@toddbluhm toddbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule looks good to me. Definitely should document the typescript >= 3.9 somewhere...probably the changelog. Also as @LinusU suggested, add a peerDependency minimum version requirement.

@mightyiam mightyiam mentioned this pull request Apr 23, 2020
Closed
@LinusU
Copy link
Contributor

LinusU commented Apr 23, 2020 •
edited
Loading

Just realised that TS 3.9 isn't released yet 😄

It's going to be released on May 12th though, which is quite soon. We could probably hold of on making another release until then? 🤔

ref: microsoft/TypeScript#37198

@LinusU
Copy link
Contributor

LinusU commented Apr 23, 2020

after #287 is merged we should probably rebase this and update the version to >= 3.9 in this PR

@mightyiam mightyiam force-pushed the prefer-ts-expect-error branch from 3db785a to f608b4f Compare April 23, 2020 10:51
@mightyiam
feat: rule @typescript-eslint/prefer-ts-expect-error
9e007cc 
BREAKING CHANGE: add rule @typescript-eslint/prefer-ts-expect-error
BREAKING CHANGE: bump typescript peerDep to `>=3.9`
@mightyiam mightyiam force-pushed the prefer-ts-expect-error branch from f608b4f to 9e007cc Compare May 16, 2020 10:56
@mightyiam mightyiam merged commit b10a230 into master May 16, 2020
@mightyiam mightyiam deleted the prefer-ts-expect-error branch May 16, 2020 10:58
@mightyiam mightyiam mentioned this pull request May 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbluhm toddbluhm toddbluhm approved these changes

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mightyiam @LinusU @toddbluhm