Skip to content

Commit

Permalink
remove old comment
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelgrinberg committed Dec 10, 2024
1 parent d177fa3 commit 6e2bd0c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
6 changes: 0 additions & 6 deletions elasticsearch_dsl/_async/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,6 @@ def as_template(
pattern: Optional[str] = None,
order: Optional[int] = None,
) -> AsyncIndexTemplate:
# TODO: should we allow pattern to be a top-level arg?
# or maybe have an IndexPattern that allows for it and have
# Document._index be that?
return AsyncIndexTemplate(
template_name, pattern or self._name, index=self, order=order
)
Expand All @@ -156,9 +153,6 @@ def as_composable_template(
pattern: Optional[str] = None,
priority: Optional[int] = None,
) -> AsyncComposableIndexTemplate:
# TODO: should we allow pattern to be a top-level arg?
# or maybe have an IndexPattern that allows for it and have
# Document._index be that?
return AsyncComposableIndexTemplate(
template_name, pattern or self._name, index=self, priority=priority
)
Expand Down
6 changes: 0 additions & 6 deletions elasticsearch_dsl/_sync/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,6 @@ def as_template(
pattern: Optional[str] = None,
order: Optional[int] = None,
) -> IndexTemplate:
# TODO: should we allow pattern to be a top-level arg?
# or maybe have an IndexPattern that allows for it and have
# Document._index be that?
return IndexTemplate(
template_name, pattern or self._name, index=self, order=order
)
Expand All @@ -146,9 +143,6 @@ def as_composable_template(
pattern: Optional[str] = None,
priority: Optional[int] = None,
) -> ComposableIndexTemplate:
# TODO: should we allow pattern to be a top-level arg?
# or maybe have an IndexPattern that allows for it and have
# Document._index be that?
return ComposableIndexTemplate(
template_name, pattern or self._name, index=self, priority=priority
)
Expand Down

0 comments on commit 6e2bd0c

Please sign in to comment.