Fix security bug #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @miguelmota, thank you very much for this example. I was doing some research about the zkEVM bridging protocol and this saved me a lot of time.
Anyway, I might be wrong, but I think I spot a security bug in the example and I wanna make sure other people using this as a reference won't make wrong assumptions.
The
L2Contract.solimplementation sets anl2Bridgevariable in the constructor, but it's never used. While checking out theonMessageReceived(...)function I noticed there's no check to make sure the call is actually from the L2 Bridge.Relying on the
originAddressalone is no enough here as any value can be passed by a malicious caller.I hope this can help.