Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for a new docusaurus icon #249

Merged

Conversation

sebastiandotdev
Copy link

Hi @miguelsolorio It's me again 😀,

Idea

This time I bring you the icon proposal for docusaurus now that I implemented its new configuration file config.ts and config.js

Preview

I don't know how you do to adjust the icon but the icon size is always a bit big for me. 🥲

Grabacion.de.pantalla.2024-10-02.a.la.s.7.mp4

@miguelsolorio
Copy link
Owner

@sebastiandotdev thanks for the PR, this icon is really bright and has a lot of details that make it distracting. I'm on the fence of this one, I generally like to re-create icons to fit the themes. Can you try an alternate style that isn't using the logo directly? Thanks.

@sebastiandotdev
Copy link
Author

@miguelsolorio Thank you for appreciating my PR, I've been researching styles other than the docusaurus icon but I can't find one :(, it seems to be the only one I can propose.

@miguelsolorio miguelsolorio self-assigned this Oct 25, 2024
@miguelsolorio miguelsolorio added icon request Request for a new icon and removed response needed labels Oct 25, 2024
Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-10-25 at 14 32 28@2x

Made some minor changes, will merge this in for now given there are no other options. Though this icon is a little hard to read at the smaller size.

@miguelsolorio miguelsolorio merged commit a58d0a3 into miguelsolorio:main Oct 25, 2024
1 check passed
@miguelsolorio miguelsolorio added this to the 0.0.21 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon request Request for a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants