status icon with input mode

[fujiwarat]

Forwarding from ibus/ibus#1992

Which distribution and version?:
Debian GNU/Linux 9 (stretch)

Which desktop environment and version?:
XFCE 4.12

Which session type?:
X11

IBus version?:
IBus 1.5.14

Issue description:

When I switch input mode between Chinese and English with Left Space, the icon in the tray does not change accordingly into English or Chinese, saying 五. I believe this is tiny bug for so beautiful ibus.

[fujiwarat]

CC'ing @yangdaweihit

[fujiwarat]

You can confirm the behavior to modify main.py

# cp /usr/share/ibus-table/engine/main.py /usr/share/ibus-table/engine/main.py.orig
# vi /usr/share/ibus-table/engine/main.py
# diff -urNp /usr/share/ibus-table/engine/main.py.orig /usr/share/ibus-table/engine/main.py
--- /usr/share/ibus-table/engine/main.py.orig	2018-03-23 15:48:17.471440383 +0900
+++ /usr/share/ibus-table/engine/main.py	2018-03-23 15:49:40.284391116 +0900
@@ -274,6 +274,9 @@ def main():
             _setup = SubElement (_engine, 'setup')
             _setup.text = setup_arg
 
+            _icon_prop_key = SubElement (_engine, 'icon_prop_key')
+            _icon_prop_key.text = 'InputMode'
+
         # now format the xmlout pretty
         indent (egs)
         egsout = tostring (egs, encoding='utf8').decode('utf-8')

# exit
% rm $HOME/.cache/ibus/bus/registry
% ibus restart

[mike-fabian]

I am not sure whether I understand that. Is the patch in the comment by Fujiwara San supposed to fix the problem?

There seems to be no icon for English mode.

[mike-fabian]

As you can see in the screenshot, the indicator at the left side of the floating panel changes from 中 to 英 when switching between Chinese and English mode. As you say, the icon in the tray is always 五 though.
But I cannot find any other ibus input method which changes the icon in the tray depending on input mode. Is this possible at all? How?

[fujiwarat]

There seems to be no icon for English mode.

Hmm.., the content of your image is not expected by me.
Did you focus on a new input context after you run ibus-daemon?

My patch means to let ibus-ui-gtk3 know 'InputMode' is the property to draw the ibus panel icon.
When ibus-table switches the input modes, ibus-table calls IBus.Engine.update_property() from ibus-table/engine/table.py:_init_or_update_property_menu() and ibus-table sends 'InputMode' property.
ibus-ui-gtk3 receives properties from ibus-table and if the property is 'InputMode', ibus-ui-gtk3 checks 'InputMode.symmbol' and draws the icon as a string.

The same implementation has been done in ibus-anthy and ibus-libpinyin (and ibus-kkc?).

[fujiwarat]

ibus read-cache should reflect the result to apply the 'icon_prop_key' patch.

[mike-fabian]

Oh, nice, I see that it works with ibus-anthy and ibus-libpinyin. It does not work with ibus-kkc.

[mike-fabian]

What could be the reason that it didn‘t work for me for ibus-table?
I applied the patch of course. And did "ibus read-cache" and rebooted.

[mike-fabian]

Oh, now I did
rm .cache/ibus/bus/registry

and rebooted again, this made it work. Great!!

[mike-fabian]

Sorry for forgetting this, you wrote it above.

[mike-fabian]

Fixed in https://github.com/mike-fabian/ibus-table/releases/tag/1.9.20

[fujiwarat]

Thank you.