Add a config variable to allow users to set the Java executable location (fixes issue #57) #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-lischke
requested changes
May 28, 2024
|
You also have to complete the DCO check. Follow the "Details" link to learn how to do that. |
parkerlamb
force-pushed
the
add_java_home_override
branch
from
2159690 to
8dfe624
Compare
…ws users to explicitly set JAVA_HOME if it is not present or if they wish to use a different Java installation. The Java executable is looked up at `${javaHomeOverride}/bin/java` in this case.
This also changes the default behavior to use `$JAVA_HOME/bin/java` as the Java executable.
If neither of `javaHomeOverride` or the JAVA_HOME environment variable are set then the extension attempts to launch `java` in PATH as before.
Fixes issue mike-lischke#57.
Signed-off-by: Parker Lamb <parkerlamb@users.noreply.github.com>
Signed-off-by: Parker Lamb <parkerlamb@users.noreply.github.com>
parkerlamb
force-pushed
the
add_java_home_override
branch
from
8dfe624 to
21d0128
Compare
|
Thanks for the comments - I think I've addressed everything |
mike-lischke
approved these changes
May 29, 2024
|
Thanks! |
|
hi @mike-lischke, could you publish a new release to include this feature? |
|
hi @mike-lischke , we really would like to get an ew release with that feature. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #57.
This adds a new configuration variable called
javaHomeOverride. This allows users to explicitly set JAVA_HOME if it is not present or if they wish to use a different Java installation. The Java executable is looked up at${javaHomeOverride}/bin/javain this case.This also changes the default behavior to use
$JAVA_HOME/bin/javaas the Java executable to be consistent.If neither of
javaHomeOverrideor the JAVA_HOME environment variable are set then the extension attempts to launchjavain PATH as before.I'm happy to adjust this as needed, feedback welcome.