Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap limit/offset #3

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Conversation

ssalinas
Copy link

@mikebell90 LIMIT needs to come first for sql. Not sure if that is the same for postgres or not. Can you test that portion? I'll continue testing with this commit in our staging branch. We can merge this to yours before it goes to master

@mikebell90
Copy link
Owner

Works both ways in Postgres happily. Thanks

@mikebell90 mikebell90 self-requested a review September 10, 2018 18:54
Copy link
Owner

@mikebell90 mikebell90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikebell90 mikebell90 merged commit 633ba9e into mikebell90:AddPostgres Sep 10, 2018
@ssalinas ssalinas deleted the fix_limit_offset branch July 17, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants