Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with "let" in Safari 9 #94

Closed
spaceemotion opened this issue May 13, 2018 · 1 comment
Closed

Issues with "let" in Safari 9 #94

spaceemotion opened this issue May 13, 2018 · 1 comment
Assignees
Labels

Comments

@spaceemotion
Copy link

spaceemotion commented May 13, 2018

Expected Behavior

No Errors

Acutal Behavior

Hundreds of Client-Side Errors (collected via Sentry)

Environment

  • PHP Version: 7.2
  • Laravel Version: 5.5.40
  • LaravelCaffeine Version: 0.6.8

Stack Trace

SyntaxError: Unexpected identifier 'lastCheck' (https://github.com/GeneaLabs/laravel-caffeine/blob/master/resources/views/script.blade.php#L2)

image


First of all, thank you for this wonderful package! Why this is not an opt-in solution our of the box with Laravel, I don't know.

I'm currently ignoring the errors in hope of seeing dwindling usage numbers of that Browser (Safari 9), but it seems like people just don't upgrade…

Since it seems to not support the "let" keyword, would it be possible to change the template to use "var" instead? This should also cover IE 10 and the like. I can also provide a PR if you're currently out of time. Cheers!

Edit: Just saw that there's already a PR open for this… #86

@mikebronner
Copy link
Owner

Thanks for reporting this! Fix coming right up.

@mikebronner mikebronner self-assigned this May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants