Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make caffeine compatible with older browsers #86

Closed
wants to merge 2 commits into from

Conversation

netpok
Copy link

@netpok netpok commented Mar 19, 2018

Many older browser does not support let and const language elements so it is required to change them to var.

Many older browser does not support let and const language elements so it is required to change them to var.
@mikebronner mikebronner self-requested a review March 19, 2018 13:04
Copy link
Owner

@mikebronner mikebronner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I will take a look over the next week or so. (My computer underwent surgery over the last few days, so I'm playing catchup and reinstalling things.)

@netpok
Copy link
Author

netpok commented Mar 19, 2018

Thanks, I updated the test cases and fixtures to reflect these changes, it's all green locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants