Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Refactor Hashes #1693

Merged
merged 27 commits into from
Sep 22, 2022
Merged

Release: Refactor Hashes #1693

merged 27 commits into from
Sep 22, 2022

Conversation

mikedh
Copy link
Owner

@mikedh mikedh commented Sep 19, 2022

  • release Change uses of hashlib.md5 to an FIPS compliant hash function #1685
  • fix Fix FIPS error thrown on useage of MD5 hash function #1684
  • deprecate every method of hashing arrays and geometry other than item.__hash__() or derived hash(item) with an October 2023 warning.
    • x.md5(), x.crc(), x.hash() are all replaced by x.__hash__ or hash(x)
    • x.__hash__ returns a long int, where hash(x) hashes the long int into a 64 bit integer. Practically I don't think this will make a difference but internal uses concatenating multiple hashes are doing it with the results of __hash__.
  • caching just tracks one hash_fast rather than fast, md5, and crc
  • hash_fast is the fastest available in this order: xxh3_64, xxh_64, blake2b, sha256.
  • you really want to install xxhash, it's like 50x faster
  • rename identifier_md5 to identifier_hash which switches from MD5 to SHA256

@mikedh mikedh merged commit cc9570b into main Sep 22, 2022
@mikedh mikedh deleted the refactor/hash branch September 22, 2022 19:45
@mikedh mikedh mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix FIPS error thrown on useage of MD5 hash function
1 participant