-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Refactor Hashes #1693
Merged
Merged
Release: Refactor Hashes #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….md5, also changed useage everywhere
Change uses of hashlib.md5 to an FIPS compliant hash function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
item.__hash__()
or derivedhash(item)
with an October 2023 warning.x.md5()
,x.crc()
,x.hash()
are all replaced byx.__hash__
orhash(x)
x.__hash__
returns a long int, wherehash(x)
hashes the long int into a 64 bit integer. Practically I don't think this will make a difference but internal uses concatenating multiple hashes are doing it with the results of__hash__
.hash_fast
rather than fast, md5, and crchash_fast
is the fastest available in this order:xxh3_64
,xxh_64
,blake2b
,sha256
.identifier_md5
toidentifier_hash
which switches from MD5 to SHA256