Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coveralls config to the travis.yml and badge to the README #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rking788
Copy link
Contributor

@mikeflynn this will require setting up and account on https://coveralls.io and adding this repository. I have setup a sample over here for my fork: https://coveralls.io/github/rking788/go-alexa.

@harrisonhjones what is the current state of the package-refactor-dev branch? currently there are no tests on the master branch so it would be really great to get at least those merged in so the coverage will have something to show.

The end goal is to submit this repo to the curated list over at https://github.com/avelino/awesome-go. Their contributions guidelines require a high quality bar. https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#quality-standards. Let me know what you think about submitting this project to the list.

It might be worth thinking about module support at this point. Maybe tagging the repo with 1.0.0 before merging these changes in would be a good idea.

@rking788
Copy link
Contributor Author

Looks like the Travis checks are failing because the coveralls project doesn't exist yet. That should start passing after it is created.

@harrisonhjones
Copy link
Contributor

Thanks for the ping @rking788. I'm not sure what the state is but I've got an Alexa project in mind and that's usually when I hack on this package. I'll make getting the dev branch ready for merge my top outside-of-work priority this week.

@rking788
Copy link
Contributor Author

Sounds good. I'm trying to get a Hacktoberfest shirt from Digital Ocean this year so I've got a few pull requests I'm submitting and trying to get merged this month. 👍

@mikeflynn
Copy link
Owner

So this is good to merge?

@rking788
Copy link
Contributor Author

So the only issue with this is that you would need to sign into coverall.io and add this repository. I logged in with my Github account and just turned on my fork of the project. Let me know if you don't want to link your account/repo in coveralls and I can try to find an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants