Remove explicit support for FrustumSurface

mikeingold · Aug 30, 2024 · a6f6b47 · a6f6b47
1 parent 7716f0f
commit a6f6b47
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -54,8 +54,7 @@ integral(f, unit_circle_bz, GaussKronrod())
 | Symbol | Meaning |
 |--------|---------|
 | :white_check_mark: | Implemented, passes tests |
-| :x: | Planned but not yet implemented |
-| :warning: | Unable to implement: parameterization not available (see [Issue #28](https://github.com/mikeingold/MeshIntegrals.jl/issues/28)) |
+| :x: | Not yet supported |
 | :stop_sign: | Not supported |
 
 ### Integral
@@ -73,8 +72,8 @@ integral(f, unit_circle_bz, GaussKronrod())
 | `Cylinder` | :white_check_mark: | :stop_sign: | :white_check_mark: |
 | `CylinderSurface` | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 | `Disk` | :white_check_mark: | :white_check_mark: | :white_check_mark: |
-| `Frustum` | :warning: | :warning: | :warning: |
-| `FrustumSurface` | :white_check_mark: | :white_check_mark: | :white_check_mark: |
+| `Frustum` | :stop_sign: | :stop_sign: | :stop_sign: |
+| `FrustumSurface` | :stop_sign: | :stop_sign: | :stop_sign: |
 | `Line` | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 | `ParaboloidSurface` | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 | `Plane` | :white_check_mark: | :white_check_mark: | :white_check_mark: |

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -123,6 +123,7 @@ end
         SupportItem("CylinderSurface{$T}", T, cylsurf(T),   1, 0, 1, 0,   1, 1, 1),
         SupportItem("Disk{$T}", T, disk(T),                 1, 0, 1, 0,   1, 1, 1),
         # Frustum -- not yet supported
+        # FrustumSurface -- not yet supported
         # Line -- custom tests below
         SupportItem("ParaboloidSurface{$T}", T, parab(T),   1, 0, 1, 0,   1, 1, 1),
         # Plane -- custom tests below
@@ -264,6 +265,7 @@ end
         @test integral(fv, cone, HAdaptiveCubature()) ≈ fill(cone_area, 3)
     end
 
+    #= DISABLED FrustumSurface testing due to long run times and seemingly-incorrect results
     # Custom tests for FrustumSurface
     @testset "Meshes.FrustumSurface" begin
         T = Float64
@@ -299,6 +301,7 @@ end
         @test integral(fv, frustum, GaussKronrod()) ≈ fill(frustum_area, 3)
         @test integral(fv, frustum, HAdaptiveCubature()) ≈ fill(frustum_area, 3)
     end
+    =#
 end
 
 ################################################################################