Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format repo and use formatter workflow #86

Closed
wants to merge 3 commits into from
Closed

Conversation

JoshuaLampert
Copy link
Collaborator

I ran the JuliaFormatter for the repo with the settings from Meshes.jl, see .JuliaFormatter.toml. This results in a lot of changes of course. Sorry for that. Are you open for automatic code formatting to ensure consistency and readability, @mikeingold? Additionally, I added another GitHub Actions workflow to automatically check the formatting for every PR, see also JuliaGeometry/Meshes.jl#965 for more details.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.59%. Comparing base (bdd69e2) to head (75964e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/utils.jl 40.00% 6 Missing ⚠️
src/integral.jl 92.30% 1 Missing ⚠️
src/specializations/BezierCurve.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   90.35%   90.59%   +0.24%     
==========================================
  Files          16       16              
  Lines         311      319       +8     
==========================================
+ Hits          281      289       +8     
  Misses         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeingold
Copy link
Owner

I like the idea of using something like JuliaFormatter to ensure consistency with a common code style, but I'll probably need to think more about which particular code style to enforce. As-is, I've landed on a particular style in this repo that is pretty self-consistent but kind of esoteric and could use an update. Personally, I think I prefer SciMLStyle, which seems slightly different from these auto-recommendations.

@JoshuaLampert
Copy link
Collaborator Author

Personally, I also prefer the SciMLStyle. This is also the one I use in my repos. I just used the style from Meshes.jl as a first proposal to get the discussion started. I'll quickly reformat. Then we can see how it looks like.

@JoshuaLampert
Copy link
Collaborator Author

I'm too lazy to resolve all the conflicts. I'll just close this PR, create a new branch, reformat there and create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants