-
-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Don't use relative paths in include directories * clang-tidy fixes * clang-tidy fixes * Added a clang-tidy driver and a minimal .clang-tidy config
- Loading branch information
1 parent
7281635
commit 82b4678
Showing
41 changed files
with
566 additions
and
713 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| #!/bin/sh | ||
|
|
||
| set -e | ||
| set -o pipefail | ||
|
|
||
| if ! [ -x "$(command -v xcpretty)" ] ; then | ||
| echo 'xcpretty is not found, aborting. (https://github.com/xcpretty/xcpretty)' | ||
| exit -1 | ||
| fi | ||
|
|
||
| if ! [ -x "$(command -v /usr/local/opt/llvm/bin/clang-tidy)" ] ; then | ||
| echo 'clang-tidy is not found, aborting. Do brew install llvm.' | ||
| exit -1 | ||
| fi | ||
|
|
||
| if ! [ -x "$(command -v jq)" ] ; then | ||
| echo 'jq is not found, aborting. Do brew install jq.' | ||
| exit -1 | ||
| fi | ||
|
|
||
| # https://github.com/xcpretty/xcpretty/issues/48 | ||
| export LC_CTYPE=en_US.UTF-8 | ||
|
|
||
| # Tools from LLVM | ||
| RUNTIDY=/usr/local/opt/llvm/bin/run-clang-tidy | ||
| TIDY=/usr/local/opt/llvm/bin/clang-tidy | ||
| APPLY=/usr/local/opt/llvm/bin/clang-apply-replacements | ||
|
|
||
| # Get current directory | ||
| SCRIPTS_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" | ||
| ROOT_DIR=$(cd "$SCRIPTS_DIR/.." && pwd) | ||
|
|
||
| # Allocate a dir for build artifacts | ||
| BUILD_DIR="${SCRIPTS_DIR}/run_clang_tidy.tmp" | ||
| mkdir -p "${BUILD_DIR}" | ||
| xattr -w com.apple.xcode.CreatedByBuildSystem true "${BUILD_DIR}" | ||
|
|
||
| # A project to build | ||
| XCODEPROJ="${ROOT_DIR}/Source/NimbleCommander/NimbleCommander.xcodeproj" | ||
|
|
||
| # Compose a list of targets to build | ||
| uts=$(xcodebuild -project ${XCODEPROJ} -list | awk -v word="Schemes:" 'BEGIN {found=0} found {if ($0 ~ /UT$/) print} $0 ~ word {found=1}' | sed 's/^[[:space:]]*//') | ||
| its=$(xcodebuild -project ${XCODEPROJ} -list | awk -v word="Schemes:" 'BEGIN {found=0} found {if ($0 ~ /IT$/) print} $0 ~ word {found=1}' | sed 's/^[[:space:]]*//') | ||
| others=("NimbleCommander-Unsigned" "RoutedIO" "info.filesmanager.Files.PrivilegedIOHelperV2") | ||
| targets=("${uts[@]}" "${its[@]}" "${others[@]}") | ||
| echo Building these targets: ${targets[@]} | ||
|
|
||
| # Common invocation of xcodebuild | ||
| XC="xcodebuild \ | ||
| -project ${XCODEPROJ} \ | ||
| -configuration Debug \ | ||
| SYMROOT=${BUILD_DIR} \ | ||
| OBJROOT=${BUILD_DIR} \ | ||
| ONLY_ACTIVE_ARCH=YES \ | ||
| COMPILER_INDEX_STORE_ENABLE=NO" | ||
|
|
||
| # Clean each target | ||
| for target in ${targets[@]}; do | ||
| $XC -scheme ${target} clean | ||
| done | ||
|
|
||
| # Build each target | ||
| echo "[]" > compile_commands.json | ||
| for target in ${targets[@]}; do | ||
| # Build the target and capture the invocation command | ||
| $XC -scheme ${target} build | xcpretty -r json-compilation-database --output compile_commands-${target}.json | ||
|
|
||
| # Remove the "-ivfsstatcache path" flags that clang-tidy doesn't understand | ||
| sed -i '' 's/-ivfsstatcache[^\"]*\.sdkstatcache//g' "compile_commands-${target}.json" | ||
|
|
||
| # Temporarily combine the new JSON with the accumulating compile_commands.json | ||
| jq -s 'add' compile_commands.json "compile_commands-${target}.json" > temp_compile_commands.json | ||
|
|
||
| # Replace the main compile_commands.json with the updated version | ||
| mv temp_compile_commands.json compile_commands.json | ||
|
|
||
| # The compile commands of this target | ||
| rm "compile_commands-${target}.json" | ||
| done | ||
|
|
||
| # Run clang-tidy in parallel via run-clang-tidy | ||
| ${RUNTIDY} \ | ||
| -p ${SCRIPTS_DIR} \ | ||
| -clang-tidy-binary ${TIDY} \ | ||
| -clang-apply-replacements-binary ${APPLY} \ | ||
| -j $(sysctl -n hw.activecpu) \ | ||
| -use-color 1 \ | ||
| -fix \ | ||
| -format \ | ||
| "${ROOT_DIR}/Source/.*" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| Checks: > | ||
| -*, | ||
| -clang-diagnostic-c99-designator, | ||
| modernize-avoid-bind | ||
| ExtraArgs: | ||
| - -Wno-unknown-pragmas |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.