[Bug]: Removing "Open system Terminal in Current Folder" from Tools Settings

[teropentis64]

Confirmation

• I have read the contributing guidelines

Version of Nimble Commander

Nimble 1.6.1 (4088), Sonoma 14.6.1

Distribution Type

Downloaded directly from the website (including Brew)

Expected Result

Removed desired tool from Tools list in settings panel.

Actual Result

Removed desired tool from Tools list in settings panel AND removed different Tool shortcut icon in application toolbar at index 1.

Steps to reproduce

1. Remove default "Open system Terminal in current folder" shortcut from application toolbar.
2. Add another one.
3. Go to Settings -> Tools and remove mentioned tool from the list.
4. Removing it from the Tools list will also remove shortcut at index 1 from application toolbar.

Additional Information

In short: removing the default tool from Tools list removes the first tool shortcut in application toolbar (which doesn't correspond to the tool removed in Tools list).

P.S
Thank You for such amazing app. I've tried all of the File Managers and Nimble is really something else.

[mikekazakov]

Hi, thanks for reporting the issue, I've tried to reproduce and indeed something fishy is happening with the toolbar.

[mikekazakov]

The toolbar addresses the external tools using their index in the storage, which causes unexpected behaviour once tools are rearranged or some of them are removed. Now thinking about it, this approach seem to be rather silly. I'm migrating the external tools to be addressed via an internal UUID which will be stable, regardless of rearranging, renaming or removal.

[teropentis64]

Yea, I thought it's addressing them by index. I would like also to report that I found rather small misplace of button which appears upon file overwriting dialog. I don't think it really deserves additional issue report.
Thanks again for Nimble!

[mikekazakov]

Should be fixed now, please try the next nightly build.

[teropentis64]

I've ran Nightly Build #248, the toolbar items works as expected.

You actually noticed something that I didn't, and thats the button was a bit higher, good catch! This is indeed fixed too, but what I actually meant the first time is easier to see there:

When the button is selected with blue rectangle, it seem's like the downarrow button overlaps the Overwrite button. I think just adding few pixels padding on the left of downarrow button would do the job. Thanks!

[mikekazakov]

Ah, I see... I've shifted it by 1px so now they are just adjacent to each other, by tbh I'm not exactly sure what is considered "best practice" for such controls nowadays, i.e. should they be together or separated. Do you have any examples from other software?

[teropentis64]

I think nothing better fits macOS design than what Apple design in the first place 😄 I remember the down arrow button is visible on "Save As" window in various apps. I've measured it in 2 apps and seems to be systemwide. It's 14px (considering the grey 1px border outline is inside the button shape).

[mikekazakov]

Ok, done.

[teropentis64]

Thanks a lot!