Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: Number of found items in search bar could benefit from padding. #399

Closed
1 task done
teropentis64 opened this issue Sep 25, 2024 · 5 comments
Closed
1 task done

Comments

@teropentis64
Copy link

Confirmation

  • I have read the contributing guidelines.

Version of Nimble Commander

Nightly Build #250, macOS 15.0

Current Appearance

befo

Expected Appearance

after

Additional Information

Readability of number of found items when searching in current folder could benefit from few pixels padding. I've moved the number left by 10px so the space between "x" circle is the same. The number is also a bit darker (not here though, on Expected Appearance screenshot)
closeup

@mikekazakov
Copy link
Owner

Agree, it should be a nice refinement.

The gap can be adjusted here:

[self addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"[m_SearchMatchesField(==50)]-(20)-|"

The font colour can be adjusted hereL

m_SearchMatchesField.textColor = [NSColor disabledControlTextColor];

@teropentis64
Copy link
Author

teropentis64 commented Sep 26, 2024

Ok, I've set it to:

[self addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"[m_SearchMatchesField(==50)]-(25)-|"

and

m_SearchMatchesField.textColor = [NSColor systemGrayColor];

the result is:
result

@mikekazakov
Copy link
Owner

Thank you. How does it look in the Dark mode? The (relatively) fixed colours might be a bit problematic as they do not "invert" when the appearance changes. For the grey colour it might be less relevant, but still.

@teropentis64
Copy link
Author

teropentis64 commented Sep 26, 2024

Good catch, I forgot to check. Seems to be ok.

darkk

@mikekazakov
Copy link
Owner

Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants