Fix drag & drop issues in SimpleDragCallback #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously SimpleDragCallback.getDragDirs() would allow dragging items that didn't implement IDraggable. Now such items are treated like ones that implement IDraggable but have 'isDraggable' set to false.
When dragging an item developers can prevent it from changing its position in the list by returning false from ItemTouchCallback.itemTouchOnMove(). This change only updates the 'to' property after an item has been moved successfully. Without this change the wrong 'newPosition' value could be delivered to ItemTouchCallback.itemTouchDropped().
When using ItemTouchHelper.startDrag() it's possible to get into a state where SimpleDragCallback.clearView() of the dropped item is called after the drag for the next item has already started. By this time the 'from' and 'to' values no longer refer to the item that was just dropped. So the wrong values are delivered to ItemTouchCallback.itemTouchDropped(). To clear the visual highlight from a dropped item a new callback method ItemTouchCallback.itemTouchStopDrag() is introduced.
Display a list where a subset of items can be reordered using a drag handle.
|
That's amazing. thank you so much for the PR. will look into it asap |
|
I believe danger is failing because of this coming from a fork and it ain't have the right permission to run :/ will look into that seperately |
mikepenz
approved these changes
Mar 17, 2021
|
Once again. thank you so much for the great PR. Released it as v5.4.0-b01 in case it's blocking the PR you have open on k-9 mail |
Awesome. Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues in
SimpleDragCallback(see individual commits) and adds a new activity showing off how to reorder (parts of) a list.FastAdapter_reorder_list.mp4