Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author empty in commit mode #1327

Closed
diwic opened this issue Apr 10, 2024 · 8 comments · Fixed by #1328
Closed

Author empty in commit mode #1327

diwic opened this issue Apr 10, 2024 · 8 comments · Fixed by #1328
Assignees

Comments

@diwic
Copy link

diwic commented Apr 10, 2024

The "AUTHOR" shows up empty when using commitMode: true. My config is like this:

    - name: Create changelog
      id: github_release
      uses: mikepenz/release-changelog-builder-action@v4
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      with:
        commitMode: true
        configurationJson: |
            {
              "categories": [
                {
                  "title": "## Changed since #{{FROM_TAG}}",
                  "labels": []
                }
              ],
              "template": "#{{CHANGELOG}}",
              "pr_template": "- #{{TITLE}} (#{{AUTHOR}})\n",
              "empty_template": "#{{OWNER}}\n#{{REPO}}\n#{{FROM_TAG}}\n#{{TO_TAG}}",
              "max_pull_requests": 1000,
              "max_back_track_time_days": 1000
            }

And the resulting changelog:

Changed since v1.0.2
fix: Add author to release notes ()

Would be nice with support to show the author of the commit. Thanks! :-)

@mikepenz
Copy link
Owner

🤔 it is mapped in the source. it would only be empty if the commit did not contain the author: https://github.com/mikepenz/release-changelog-builder-action/blob/develop/src/pr-collector/commits.ts#L119C7-L119C13

@mikepenz mikepenz self-assigned this Apr 10, 2024
@diwic
Copy link
Author

diwic commented Apr 10, 2024

@mikepenz
Copy link
Owner

Can you please try v5.0.0-a03 and validate it works for you that way?

@diwic
Copy link
Author

diwic commented Apr 10, 2024

Changing from @v4 to @v5.0.0-a03 removes all commit info. It shows just the name of the package and tags with no formatting.

@mikepenz
Copy link
Owner

Apologies. v5 is a major upgrade so it could be some other pieces are not comaptible. I can cherry pick the change on v4, to check it there

@mikepenz
Copy link
Owner

Here's the same commit on the 4.x variant of the action:
9784d5c

Use it via @9784d5c663eed13a5d432f65e1922df2e75ab0f6

@diwic
Copy link
Author

diwic commented Apr 10, 2024

It works better now, thanks for the quick support!

Although, I also messed around with which email addresses were associated with my account, so there is a chance that the cause for things to be fixed are due to my own changes rather than yours.

@mikepenz
Copy link
Owner

yeah it might be that if the commit identity was not associated with a GitHub identity that it may be empty. It should have contents now either way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants