Refactor transform.ts and others #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. overall looks good. Due to the size it might take me a bit to get this reviewed. |
|
No rush! Thanks for taking the time to review it! |
mikepenz
force-pushed
the
refactor/transform-and-misc
branch
from
6edf446
to
a594949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring in preparation of new features:
Extracted more functions out of the large
buildChangelogfunction as well as making the new and existing ones either deal with building the placeholder maps (which I renamed to "template contexts" [inspired by Scriban/Liquid] since I thought too many things were called placeholder something) or deal with "rendering" i.e. substituting tokens in the template strings.