Backwards compatibility with linux pre 2.6.33 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for listing inotify watches in a /proc/{}/fdinfo/{} file
was added in linux kernel 3.8; this utility relies on that information
to count the number of watches in use.
This commit detects when the inotify info is not provided in fdinfo and
ommits the "Watches" column and stats when printing the found info.
Author-Rebase-Consent: https://No-rebase.github.io
Starting with kernel 2.6.33, inotify descriptors were listed as in
/proc/{}/fd as "anon_inode:inotify". Prior to this version, they
were listed as "inotify"
This commit allows both nomenclatures, making the utility compatible
with kernels older than 2.6.33
Author-Rebase-Consent: https://No-rebase.github.io
The -Wimplicit-fallthrough=2 warning was first implemented in GCC 7.1. This would cause compiling with earlier GCC to fail. This warning (albeit with =3 format) was included in -Wall which is more stringent. This incantation requires fall-through case statements to be specified case sensitively. In any case, the codebase here does not include any fall-through waivers, so changing to -Wall does not require any other adaptations. This commit removes the -Wimplicit-fallthrough argument from the Makefile, and replaces it with -Wall which is more stringent, and allows old GCC's to successfully compile the utility. Author-Rebase-Consent: https://No-rebase.github.io
Closed
|
Thanks Radu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of 3 commits implements:
Compatibility with kernels older than 2.6.33
anon_inode:inotify" linux used "inotify" as filename in /proc/.../fdCompatibility with kernels older than 3.8
Compatibility with GCC older than 7.1
-Wimplicit-fallthrough=argumentThis PR also resolves my concern in #10 (comment) about missing info on old kernels
Please merge this PR rather than rebase.