-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scopes "module" or "class" circumvent the blocking #45
Comments
Looking into the pytest socket code and the pytest documentation, this seems to be expected behavior:
Hence, in example 3 above the Maybe worth mentioning this in the documentation. |
Hi @ymyke ! Where in the documentation would you have expected to find this kind of specific behavior definition? |
Maybe in a separate section called "Caveats" or "Gotchas"? Or in an FAQ section? Maybe with a title such as "Network access in some of my fixtures work despite disabling sockets, why?". |
Resolves #45 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Resolves #45 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Thanks for the great plugin!
I noticed the following:
Example 1:
This will raise
SocketBlockedError
, as expected.Example 2:
This will also raise the
SocketBlockedError
. Also as expected.Example 3:
This will pass. No exception.
To me, this was unexpected and lead to some debugging headaches.
Is this intended behavior or a bug? Is there a way to make the plugin also prevent cases such as this one?
The text was updated successfully, but these errors were encountered: