Skip to content

Commit

Permalink
chore: remove unreachable condition
Browse files Browse the repository at this point in the history
Now that Python validates the addresses more strictly, we won't hit the
condition any longer.

If we wish to preserve this condition, we could also pass `strict=False`
to `getaddresses()`, but that seems to be counter to our desire of
having a valid email address.

Refs: python/cpython#123766

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
  • Loading branch information
miketheman committed Sep 12, 2024
1 parent 9422a8f commit 76dddcf
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions warehouse/rss/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ def _format_author(release):
return None
author_emails.append(author_email)

if not author_emails:
return None
return ", ".join(author_emails)


Expand Down

0 comments on commit 76dddcf

Please sign in to comment.