Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] number imagefap images by default #1746

Closed
pirate486743186 opened this issue Aug 3, 2021 · 5 comments · Fixed by #5887
Closed

[feature] number imagefap images by default #1746

pirate486743186 opened this issue Aug 3, 2021 · 5 comments · Fixed by #5887

Comments

@pirate486743186
Copy link

The downloader works fine, but the filenames have only IDs, so the order is a mess.
@Hrxn
Copy link
Contributor

Hrxn commented Aug 3, 2021 •
edited
Loading

Can you try this for the "filename": setting? "{category}_{gallery_id}_{num}_{filename}.{extension}"

(i.e. with {num}added)

@pirate486743186
Copy link
Author

yea it works fine. It should be in the defaults, i'm not just asking for help.
I still think configuration in gallery-dl is too complicated.

@pirate486743186 pirate486743186 changed the title imagefap images are not numbered [minor] imagefap images are not numbered Aug 4, 2021
@Hrxn
Copy link
Contributor

Hrxn commented Aug 4, 2021

This issue can be closed.

@pirate486743186
Copy link
Author

pirate486743186 commented Aug 4, 2021 •
edited
Loading

and also pad it with enough zeros. There's a giant gallery with 179447 images...
https://www.imagefap.com/gallery.php?type=1&gen=0&sort=pics&order=1&filter_size=&filter_date=

@pirate486743186 pirate486743186 changed the title [minor] imagefap images are not numbered [feature] number imagefap images by default Sep 14, 2021
@pirate486743186
Copy link
Author

I meant that this should be the default...

@ShruggZoltan ShruggZoltan mentioned this issue Jul 26, 2024
Merged
mikf added a commit that referenced this issue Jul 28, 2024
@mikf
merge #5887: [imagefap] add '{num}' to default filenames (#1746)
304bb4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Numbers images obtained from imagefap by default. ShruggZoltan/gallery-dl
2 participants
@pirate486743186 @Hrxn