Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skeb] Ignore thumbnail #2047

Closed
108EAA0A opened this issue Nov 21, 2021 · 3 comments
Closed

[skeb] Ignore thumbnail #2047

108EAA0A opened this issue Nov 21, 2021 · 3 comments

Comments

@108EAA0A
Copy link

Currently, thumbnails are always downloaded.
Thumbnails are often low-res or blurred, and are not needed in many cases.
There needs to be a way to ignore thumbnails using options or other methods.

if "og_image_url" in resp:
post["content_category"] = "thumb"
post["file_id"] = "thumb"
post["file_url"] = resp["og_image_url"]
yield post

@108EAA0A
Copy link
Author

This is not directly related to this issue, but is og_image_url a thumbnail in the first place?
I think the actual thumbnail displayed on the user page is thumbnail_image_urls["src"] from the user works API(https://skeb.jp/api/users/{}/works).

@108EAA0A 108EAA0A changed the title [Enhancement] [skeb] Ignore thumbnail [skeb] Ignore thumbnail Nov 21, 2021
@alice945
Copy link
Contributor

I added a 'thumbnails' option in my pull request, disabled by default (#2051)
I choose to use the og_image_url thumbnail rather than the one on the main page because it is the highest quality, sometimes having a greater width than the preview.

@mikf
Copy link
Owner

mikf commented Nov 23, 2021

As a more general solution, --filter "content_category != 'thumb'" would have also been possible.

@mikf mikf closed this as completed Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants