Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kemonoparty] Post revision unlisted downloads #4706

Closed
komoreshi opened this issue Oct 23, 2023 · 4 comments
Closed

[kemonoparty] Post revision unlisted downloads #4706

komoreshi opened this issue Oct 23, 2023 · 4 comments

Comments

@komoreshi
Copy link

komoreshi commented Oct 23, 2023

Using the new revisions extractor option appears to cause a loop when downloading. Config below:

"kemonoparty":
        {
            "revisions": true,
            "filename": "{id:?/_/}{revision_id}_{title}_{num:>02}_{filename[:180]}.{extension}"
        },

It downloads the lastest post successfully, but loops indefinetly afterward for all subsequent revisions.

image

The revision id's in the above image also don't exist for that post, so I'm not sure where they're being pulled from.

@a84r7a3rga76fg
Copy link

"archive-format": "{subcategory}_{user}_{id}_{num}_{hash}"
Use an archive and the revision IDs do exist in your picture, it's 7685978, 7622080, etc.

@komoreshi
Copy link
Author

komoreshi commented Oct 23, 2023

My mistake, it doesn't loop indefinitely but instead downloads 12 different revisions for the post in the above picture - that's in line with what the API is returning. Kemono is only listing 2 on the actual page which is strange. Wonder if the webpage is only displaying the oldest and newest, or not showing duplicates.

Is there a way to return the highest and lowest revision IDs in the config using formatting? I don't use an archive.

@komoreshi komoreshi changed the title [kemonoparty] Post revision download loop [kemonoparty] Post revision unlisted downloads Oct 24, 2023
@mikf
Copy link
Owner

mikf commented Oct 24, 2023

The webpage is definitely showing more than 2 for other posts and is not hiding duplicates.
https://kemono.party/patreon/user/3161935/post/68231671 for example has 10 and all of them seem identical.

For your post, the API lists 12 items
https://kemono.su/api/v1/fanbox/user/853087/post/2366569/revisions
while the website only lists 1 revision + the original post.

I'd guess this is an error on kemono's side.

@komoreshi
Copy link
Author

Thanks, ended up assuming that later shortly after. Took @a84r7a3rga76fg's advice and started using an archive to dedup the revisions.

mikf added a commit that referenced this issue Jan 15, 2024
A SHA1 hexdigest of other relevant metadata fields like
title, content, file and attachment URLs.

This value does NOT reflect which revisions are listed on the website.
Neither does 'edited' or any other metadata field (combinations).
bradenhilton pushed a commit to bradenhilton/gallery-dl that referenced this issue Feb 5, 2024
…f#5013)

A SHA1 hexdigest of other relevant metadata fields like
title, content, file and attachment URLs.

This value does NOT reflect which revisions are listed on the website.
Neither does 'edited' or any other metadata field (combinations).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants