-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deviantart] support user avatars and banners #4995
Comments
I forgot to mention when this issue was created what I've learned about deviantart avatars.. Another thing is that users often have several accessible avatars. When they upload an avatar with a different extension then the one with the old extension isn't deleted. So there's often 3 avatars: gif, png and jpg (just replace the extension) |
I had tried finding something better than Now I've found an avatar that works with https://a.deviantart.net/avatars-original/a/m/amandajeansart.jpg?15 |
They probably had an avatar that was big enough for original resolution then they changed it to something smaller. I've wanted to save all the versions I could but that's probably not best for everybody. There's probably no way to tell what the biggest current url is except trying all of the sizes for each user. You can probably get the biggest current profile picture by getting all of the sizes then getting the biggest size that matches the smallest size. The smallest resolution should probably always be the right one. If we were to only download one I'd go for the biggest size. It's either go for the biggest size which is probably usually correct or be stuck with the smallest size for everything which kinda sucks. By the way is this for commenters too? That would be really nice. I said "probably" a lot :/ |
Downloaded files are just binary blobs for gallery-dl. There is no way to programmatically tell if one size "matches" another. A human (and nowadays probably AI) can do that, but gallery-dl can't even compare pixels.
Not yet. But that should be doable and won't even cost any extra API requests since comments have the user icon included. |
Just found one where different file extensions result in different images. https://a.deviantart.net/avatars/a/n/anoya.png edit: https://a.deviantart.net/avatars-big/a/n/anoya.png # same as /avatar/ |
I downloaded version 1.26.6 and tried downloading the avatar for my account and I got this error. It also doesn't seem to work for other accounts. [deviantart][debug] Using DeviantartAvatarExtractor for 'https://www.deviantart.com/doajcblogger/avatar' |
This happens when "deviantart": {
"avatar": {
"comments": false
}
} edit: fixed in 5f9a98c |
Does it stop checking avatar formats after the first successful one? I was hoping to get all of the formats specified since they are different images usually. |
It will try to download all formats. You might have to adjust |
… when using 'comments-avatars' This also has the added benefit of making it possible to download comment avatars from users without a valid user profile entry, like deleted users.
From #146 (comment)
The text was updated successfully, but these errors were encountered: