Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[naverwebtoon][bug][question]naverwebtoon {title} not working and some configuration question #5120

Closed
gcfvfhg opened this issue Jan 27, 2024 · 10 comments

Comments

@gcfvfhg
Copy link

gcfvfhg commented Jan 27, 2024

1.naverwebtoon {title} not working

I use Standalone Executable v1.26.7

configuration:

            "directory": ["{category}","{title_id}_{comic}","{episode}-{title}"],
            "filename": "ch{episode}-page{num:>03}.{extension}"

Running results:


C:\...\test1>gallery-dl https://comic.naver.com/bestChallenge/list?titleId=620732
* .\naverwebtoon\620732_백일몽화원\1-예고하는 이야기\ch1-page001.jpg
* .\naverwebtoon\620732_백일몽화원\1-예고하는 이야기\ch1-page002.jpg
* .\naverwebtoon\620732_백일몽화원\1-예고하는 이야기\ch1-page003.jpg
* .\naverwebtoon\620732_백일몽화원\1-예고하는 이야기\ch1-page004.jpg
* .\naverwebtoon\620732_백일몽화원\2-1화...향(向)\ch2-page001.jpg
* .\naverwebtoon\620732_백일몽화원\2-1화...향(向)\ch2-page002.jpg
* .\naverwebtoon\620732_백일몽화원\2-1화...향(向)\ch2-page003.jpg
* .\naverwebtoon\620732_백일몽화원\3-2화... 방(訪)\ch3-page001.jpg
* .\naverwebtoon\620732_백일몽화원\3-2화... 방(訪)\ch3-page002.jpg
* .\naverwebtoon\620732_백일몽화원\3-2화... 방(訪)\ch3-page003.jpg
* .\naverwebtoon\620732_백일몽화원\3-2화... 방(訪)\ch3-page004.jpg


C:\....\test1>gallery-dl https://comic.naver.com/challenge/list?titleId=818033
* .\naverwebtoon\818033_6번째 후일담\1-\ch1-page001.jpg
* .\naverwebtoon\818033_6번째 후일담\1-\ch1-page002.jpg
* .\naverwebtoon\818033_6번째 후일담\1-\ch1-page003.jpg
* .\naverwebtoon\818033_6번째 후일담\1-\ch1-page004.jpg
* .\naverwebtoon\818033_6번째 후일담\1-\ch1-page005.jpg
* .\naverwebtoon\818033_6번째 후일담\1-\ch1-page006.jpg
* .\naverwebtoon\818033_6번째 후일담\1-\ch1-page007.jpg
  .\naverwebtoon\818033_6번째 후일담\1-\ch1-page008.jpg


C:\....\test1>gallery-dl https://comic.naver.com/challenge/list?titleId=818932
* .\naverwebtoon\818932_스탈맨\1-\ch1-page001.jpg
* .\naverwebtoon\818932_스탈맨\1-\ch1-page002.jpg
* .\naverwebtoon\818932_스탈맨\1-\ch1-page003.jpg
* .\naverwebtoon\818932_스탈맨\1-\ch1-page004.jpg
* .\naverwebtoon\818932_스탈맨\2-\ch2-page001.jpg
* .\naverwebtoon\818932_스탈맨\2-\ch2-page002.jpg
* .\naverwebtoon\818932_스탈맨\2-\ch2-page003.jpg
  .\naverwebtoon\818932_스탈맨\2-\ch2-page004.jpg

For https://comic.naver.com/challenge

{title} is not displayed.

@gcfvfhg
Copy link
Author

gcfvfhg commented Jan 27, 2024

2.question about executing multiple gallery-dl at the same time

I'm sorry for asking stupid questions.
I have read the content in the link below, but I am worried that my understanding is wrong.
https://github.com/mikf/gallery-dl/issues?q=multiple+instances
#2755 (comment)

I have executed both EX 1 and EX 2.
I haven't found any errors so far,but i'd like some verification.

EX ①:

I place files in these locations:

D:\test1\gallery-dl.conf
D:\test1\gallery-dl.exe
D:\test2\gallery-dl.conf
D:\test2\gallery-dl.exe
D:\test3\gallery-dl.conf
D:\test3\gallery-dl.exe

The contents of three files may be different:

D:\test1\gallery-dl.conf
D:\test2\gallery-dl.conf
D:\test3\gallery-dl.conf

I didn't create three files:

%APPDATA%\gallery-dl\config.json
%USERPROFILE%\gallery-dl\config.json
%USERPROFILE%\gallery-dl.conf

I open three CMD windows and execute D:\test1\gallery-dl.exeD:\test2\gallery-dl.exeD:\test3\gallery-dl.exe at the same time

1

EX ②:

I place files in locations:

D:\test1\gallery-dl.conf
D:\test1\gallery-dl.exe

I open three CMD windows and execute three commands at the same time:

gallery-dl https://twitter.com/dailytouhous/media
gallery-dl https://comic.naver.com/webtoon/list?titleId=808198
gallery-dl https://comic.naver.com/webtoon/list?titleId=820354

2

Are EX 1 and EX 2 reasonable ways to run gallery-dl?Will it conflict?
"EX 2 "is called run multiple instances of gallery-dl ,it is right?
Is the number of cmd windows I open and run gallery-dl equal the number of instances?

@gcfvfhg
Copy link
Author

gcfvfhg commented Jan 27, 2024

3.question about readme.rst

https://github.com/mikf/gallery-dl#id21

It is possible to use more than one configuration file at a time.In this case, any values from files after the first will get mergedinto the already loaded settings and potentially override previous ones.

Does this mean that users create their own configurations in these three places at the same time??who previous ones?
%APPDATA%\gallery-dl\config.json
%USERPROFILE%\gallery-dl\config.json
%USERPROFILE%\gallery-dl.conf
(I know my question is weird and I want to explain why I can't understand it)

@mikf
Copy link
Owner

mikf commented Jan 27, 2024

1.naverwebtoon {title} not working

Fixed in 22647c2

2.question about executing multiple gallery-dl at the same time

Both EX ① and EX ② are perfectly fine.

The only way they interfere with one another is by writing to the same log file, using the same download archive, or downloading into the same directory, but you'd have had to be the one who configured gallery-dl that way for it to be a problem. If you didn't touch any of what I mentioned, it won't be a problem.

3.question about readme.rst

On Unix platforms, where gallery-dl also reads from /etc/gallery-dl.conf, you could have a system-wide config file, whose settings would then get overridden by settings in user-specific config files like ~/.config/gallery-dl/config.json.

This is not so much a thing on Windows, but gallery-dl would theoretically load from all three of the config file locations you listed if they existed.

@gcfvfhg
Copy link
Author

gcfvfhg commented Jan 27, 2024

thank you for your help


It is possible to use more than one configuration file at a time. In this case, any values from files after the first will get merged into the already loaded settings and potentially override previous ones.

This sentence is for Linux, macOS, etc. rather than window?


Linux, macOS, etc.:
/etc/gallery-dl.conf
${XDG_CONFIG_HOME}/gallery-dl/config.json
${HOME}/.config/gallery-dl/config.json
${HOME}/.gallery-dl.conf

Assume that the contents of the four files are different.

Assume there is /etc/gallery-dl.conf

Suppose there is one of the following three:
${XDG_CONFIG_HOME}/gallery-dl/config.json
${HOME}/.config/gallery-dl/config.json
${HOME}/.gallery-dl.conf

run gallery-dl https://*

The download result obtained will be based on the configuration of /etc/gallery-dl.conf instead of the other three.

Is my understanding correct?


I'm sorry for my poor understanding
thank you for your help

@mikf
Copy link
Owner

mikf commented Jan 27, 2024

The download result obtained will be based on the configuration of /etc/gallery-dl.conf instead of the other three.

No, it loads all of them and merges their settings.

Here's an example: Given you had these two config files

/etc/gallery-dl.conf

{
    "a": 1,
    "b": 2
}

${HOME}/.config/gallery-dl/config.json

{
    "b": 7,
    "c": 3
}

gallery-dl would run with the same config settings as if you had only one config file containing

{
    "a": 1,
    "b": 7,
    "c": 3
}

@gcfvfhg
Copy link
Author

gcfvfhg commented Jan 27, 2024

/etc/gallery-dl.conf

{
    "b": 1

}

${XDG_CONFIG_HOME}/gallery-dl/config.json

{
    "b": 2

}

${HOME}/.config/gallery-dl/config.json

{
    "b": 3

}

${HOME}/.gallery-dl.conf

{
    "b": 4
}

gallery-dl would run with the same config settings as if you had only one config file containing

{
    "b": 4
}


Is my understanding correct?

@gcfvfhg
Copy link
Author

gcfvfhg commented Jan 27, 2024

%APPDATA%\gallery-dl\config.json

{
    "b": 1

}

%USERPROFILE%\gallery-dl\config.json

{
    "b": 2

}

%USERPROFILE%\gallery-dl.conf

{
    "b": 3

}

gallery-dl would run with the same config settings as if you had only one config file containing

{
    "b": 3
}


Then does this rule also apply to windows?
Is my understanding correct?

@rautamiekka
Copy link
Contributor

Then does this rule also apply to windows? Is my understanding correct?

He said:

This is not so much a thing on Windows, but gallery-dl would theoretically load from all three of the config file locations you listed if they existed.

... assuming Python somehow resolves the paths to valid files.

@mikf
Copy link
Owner

mikf commented Jan 27, 2024

It also applies to Windows.

The order in which config files get loaded (and merged) is the as same as they are listed in the README here. So yes, your assumption from #5120 (comment) is correct.

The extra config file from

When run as executable, gallery-dl will also look for a gallery-dl.conf file in the same directory as said executable.

would get loaded after all other possible configs, and -c/--config etc after that.

@gcfvfhg
Copy link
Author

gcfvfhg commented Jan 28, 2024

I think i understand
Thank you for your patient explanation

@gcfvfhg gcfvfhg closed this as completed Jan 28, 2024
bradenhilton pushed a commit to bradenhilton/gallery-dl that referenced this issue Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants