-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeviantArt Oauth: write token to conf #616
Comments
Writing to a conf file isn't possible, but writing the token to cache might work.
You can use as many config files as needed, 2-3 through the default config paths and an arbitrary amount through (It might be useful to support an |
Oh interesting! I have used such "configuration stacking" in Jekyll yamls, but didn't know gallery-dl would allow this. I think it would be wholly intuitive for gallery-dl to save the refresh-token on first oauth in the same way it renews and keeps in cache throughout a long download cycle. Definitely a feature request, but seems sensible. Do you have any concerns over this behaviour? |
Writing the token is currently disabled by default and must be enabled with 'extractor.oauth.cache'. 'extractor.deviantart.refresh-token' must be set to '"cache"' to use the cached token.
913b833 is the first attempt of implementing this. Most of it is hidden behind options (see commit message), and it only works for DeviantArt at the moment, but I'll probably enable this by default and implement it for everything using OAuth in the next "big" release. |
@mikf Are there any usage changes since these commits? Do you still need |
(you might want to read #807 (comment) and #807 (comment)) (*) support for Mastodon instances is still missing |
This is all fantastic, thank you @mikf !! Feel free to close this unless you want to wait until Mastodon is settled. |
I'm finding it inconvenient using the Oauth:deviantart feature then having to copy the refresh-token to my .conf before I run the task. As I may be flipping between multiple .conf files for different run tasks, it means each .conf needs to be updated (or am I incorrect?)
It would be very useful for the authorization process to take the received token and write it to the .conf or cache which it pulled the id/secret from.
Thanks!
The text was updated successfully, but these errors were encountered: