Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Twitter] After update to 1.14.1 #833

Closed
open-mindt opened this issue Jun 15, 2020 · 1 comment
Closed

[Twitter] After update to 1.14.1 #833

open-mindt opened this issue Jun 15, 2020 · 1 comment

Comments

@open-mindt
Copy link

I faced some problems.

  • Videos=false, Instead of skipping video, download screenshot.
PS D:\> gallery-dl https://twitter.com/F1/status/1272280401533378561
* .\gallery-dl\twitter\F1\1272280401533378561_1.mp4

PS D:\> gallery-dl -o videos=false https://twitter.com/F1/status/1272280401533378561
* .\gallery-dl\twitter\F1\1272280401533378561_1.jpg
PS D:\> gallery-dl -c test.json -s https://twitter.com/f1/status/1269672421138849797
# Tiametmarduk 1269672421138849797-2020-06-07 16_47_49_1.mp4

PS D:\> gallery-dl -c test.json -s https://twitter.com/Tiametmarduk/status/1269669771475333122
# Tiametmarduk 1269669771475333122-2020-06-07 16_37_17_1.mp4
  • I don't know when the quoted content started, but some users use it a lot, not retweet.
    When download the timeline, Download quoted content like Its own tweet. I hope quoted contents is handled like retweet.
PS D:\> gallery-dl -c test.json -s https://twitter.com/F1/status/1272214532056899585
# F1 1272214532056899585-2020-06-14 17_09_15_1.jpg

PS D:\> gallery-dl -c test.json -s https://twitter.com/redbullracingES/status/1271742798245568512
# redbullracingES 1271742798245568512-2020-06-13 09_54_45_1.jpg

Finally, I always appreciate your hard work using this application and hope you don't get too stressed out with this report.

mikf added a commit that referenced this issue Jun 16, 2020
when 'videos' is set to False
mikf added a commit that referenced this issue Jun 18, 2020
The idea was to have less metadata clutter for most Tweets were
'author' and 'user' are the same (non-retweets), and only provide
a 'user' field.

The original Tweet author could be gotten with
{author[…]|user[…]}, but basically no one knows about that.
@mikf
Copy link
Owner

mikf commented Jun 18, 2020

Videos=false, Instead of skipping video, download screenshot.

Fixed in b943941

Retweeted tweet filename problem.

See #831 (comment)

The tweet_id and date of the retweet file and the original file do not match.

This was already the case before the Twitter rewrite in 1.14.1 and it kind of makes sense. A retweet is a different thing than the original tweet, and both have different IDs and creation times on Twitter's end.

I don't know when the quoted content started, but some users use it a lot, not retweet.
When download the timeline, Download quoted content like Its own tweet. I hope quoted contents is handled like retweet.

The old Twitter code before 1.14.1 treated quoted Tweets the same as Retweets, but that's kind of wrong, because he original Tweet and the Tweet that quotes it both have their own separate content.

Maybe just splitting them internally and treating them as 2 distinct objects instead of 1 like it's currently done works here ...

@mikf mikf changed the title [Twitter] After update to 1.4.1 [Twitter] After update to 1.14.1 Jun 18, 2020
mikf added a commit that referenced this issue Jun 21, 2020
- filter them when 'retweets' is disabled
- set 'author' to the creator of the quoted tweet

like it was before the rewrite
@mikf mikf closed this as completed Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants