Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deviantart] [#1776] Remove the "you need session cookies to download mature scraps" warning #1777

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

Scripter17
Copy link
Contributor

To my knowledge, gallery-dl can download mature scraps from deviantart without cookies depsite the warning (see #1776 for details)

I haven't tested all the possible edge-cases yet (hence the PR being a draft). I'm putting this here mostly just to get used to pull requests

@Scripter17
Copy link
Contributor Author

I tested --include scraps, gallery/scraps, gallery?catpath=scraps, and linking to the art directly and they all seem to work without cookies, API keys. or both

I don't think there's any case where this doesn't work

@Scripter17 Scripter17 marked this pull request as ready for review August 15, 2021 19:04
@mikf
Copy link
Owner

mikf commented Aug 16, 2021

You should also remove lines 893, 897, and 898:


if self._warning:
DeviantartScrapsExtractor._warning = False

@Scripter17
Copy link
Contributor Author

There wouldn't happen to be any reference to mature scraps needing cookies in the documentation, would there?

I'm doing a quick scan just to check but I'm pretty sure it's mostly just issues that refer to it

@mikf
Copy link
Owner

mikf commented Aug 16, 2021

I don't think so. This warning was the only thing about dA cookies.

@mikf mikf merged commit 1f02878 into mikf:master Aug 16, 2021
mikf added a commit that referenced this pull request Nov 2, 2022
…download mature scraps" warning (#1777)"

This reverts commit 1f02878.

Mature scraps do yet again require cookies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants