[Twitter] [#1532] Add account URL to --write-metadata and expand t.co links in user descriptions #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n user descriptions
|
:/ |
Why yes flake8, 84 *is* greater than 79
This is why people don't like linters
mikf
added a commit
that referenced
this pull request
Aug 26, 2021
mikf
added a commit
that referenced
this pull request
Aug 26, 2021
mikf
added a commit
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wouldn't make much sense to put these in separate pull requests so I just joined them
It's messy code and still needs to be tested but basically it
--write-metadatain the same way 41457db was doneSide note: The JSON for the t.co replacement stuff is really weird. If there's no t.co links in the bio
user["entities"]["description"]is empty but for the "my site" linkuser["entities"]["url"]is just gone. You'd think it'd be a bit more consistent than that