[twitter] apply tweet type checks before uniqueness check #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not consider a tweet seen before applying 'retweet', 'quote' and 'reply' checks. Otherwise the original tweets will also be skipped if the "derivative" tweets and the original tweets are from the same user.
ClosedPort22
commented
Dec 25, 2022
| @@ -2691,6 +2691,13 @@ Default | |||
| Description | |||
| Fetch media from quoted Tweets. | |||
|
|
|||
| If the value is ``true``, then gallery-dl will try to fetch | |||
| the quoted (original) Tweet when it sees the Tweet which quotes it. | |||
There was a problem hiding this comment.
Technically this is not what really happens, since Twitter's API returns both the quoting and the quoted tweet, and gallery-dl simply discards or accepts the quoted tweet depending on quoted. But I think it's easier to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3439 (although this is technically a separate issue).
See also: #3439 (comment), 1d14928