-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] update OAuth guide in README.rst #3496
Conversation
adcd51d
to
0e8657e
Compare
*gallery-dl* supports user authentication via OAuth_ for some extractors. | ||
This is necessary for | ||
``pixiv`` | ||
and optional for | ||
``deviantart``, | ||
``flickr``, | ||
``reddit``, | ||
``smugmug``, | ||
``tumblr``, | ||
and ``mastodon`` instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One could argue that it is not entirely optional for Mastodon instances, since it is required to map user name to ID, but I have no idea how to accurately describe that here without being too verbose.
.../users/username requires an access token
.../users/id:12345 works without
(for instances that are not supported by default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current description is okay, since it's not entirely non-functional without the token, unlike Pixiv. Maybe a more detailed description could be added to configuration.rst
(although extractor.mastodon.access-token
is currently undocumented).
And by the way, I think the dot in |
It's never been used like that anyway. |
I do use this feature from time to time. Both |
I mean it's never used with the TLD. |
That's the identifier used by the instance: gallery-dl/gallery_dl/extractor/mastodon.py Lines 72 to 73 in a918ce2
I think it would work just fine in the config file, which doesn't use dot notation, but perhaps something like an underscore would've been a better choice. |
Ok, fair enough. |
Yeah, it was a bad decision to use I think it would be best to eventually (v2.0?) change the dot notation for |
No description provided.